fix(langchain): use override in model fallbacks #33716
Open
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset model_settings when switching to fallback model to prevent provider-specific parameters from causing errors. Fixes langchain-ai#33709
github-actions
bot
added
langchain
eyurtsev
reviewed
Oct 29, 2025
| # Try fallback models | ||
| for fallback_model in self.models: | ||
| request.model = fallback_model | ||
| request.model_settings = {} |
Collaborator
There was a problem hiding this comment.
Could you do this using override? request = request.override(model=fallback_model)
Collaborator
|
Taking over the implementation |
Contributor
Author
|
Thank you so much for the helpful review and for taking over the implementation! |
Collaborator
|
@bart0401 I pushed this to avoid the mutation in place on the model parameter, not the model_settings. We'd need a different solution for model settings, since we can't assume it's safe to clear them |
eyurtsev
changed the title
bart0401
added a commit
to bart0401/bart0401
that referenced
this pull request
Oct 29, 2025
|
But what if your fallback model is also an Anthropic model? You shouldn't be removing the context-control from it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Clears
model_settingswhenModelFallbackMiddlewareswitches to a fallback model. Previously, provider-specific settings like Anthropic'scache_controlwould persist and cause errors when passed to other providers (e.g., OpenAI throwingTypeError: unexpected keyword argument 'cache_control').Issue: Fixes #33709
Dependencies: None
Testing:
model_settingsare cleared on fallback